GoldenEye 007 Nintendo 64 Community, GoldenEye X, Nintendo 64 Games Discussion

[Kerr Avon]

As I mentioned in

http://www.shootersforever.com/forums_message_boards/viewtopic.php?p=53030#53030

I think I've found a bug in Perfect Dark Setup Editor 1.09. If you try to patch a rom file that has the wrong CRC value (say if it's pre-patched) then Perfect Dark Setup Editor 1.09 throws up an error (as it should), but creates a zero length file with the file name you chose to save the finished rom to.

For example, ;

1. Select XDelta Patching > Apply PD XDelta Patch

2. Choose "Perfect Dark (U) GE Weapons work in multiplayer.z64" (note: this is prepatched, and will therefore fail the patching process)

3. Choose "PDSimsUseTimedMinesNTSC.xdelta"

4. Choose "Perfect Dark Sims-mines and GE guns.z64" (this doesn't refer to a file that already exists, it's the name you choose to save the finished, patched rom to).

You get an error saying "Unknown error patching, possibly input ROM CRC mismatch", which is as it should be, but a file has been created called "Perfect Dark Sims-mines and GE guns.z64" that is zero bytes long. This file should not be created at all unless the patching is successful.



Also, as a feature request, would it be possible to add an option to the "Apply PD XDelta Patch" function, so that the CRC check can be ignored? This way, the user could patch an already pre-patched rom file, though of course then there'd be no guarrantee that the two or more patched wouldn't conflict with each other.


Or perhaps add an option to "Apply multiple PD XDelta Patches", so that the user could choose two or more patches, and then the Perfect Dark Setup Editor 1.09 would check that the patches don't conflict, and apply them to the rom. And if they do conflict then warn the user, and offer the choice of ;

- Abort patching

- Re-choose patch(es) to apply

- Apply patches, but allow the user to choose the order in which the patches are applied.

[SubDrag]

It's not a bug and is intentional (but I do appreciate all bug reports). You can't apply most patches together, as the files changed are compressed in the ROM. So mixing and matching patches on the compressed area will either overwrite the other, or cause a crashing hybrid. You have to patch one, then manually update the other ROM. It works a little better in GE, when you need more than one patch we use IPS format, so you don't get a CRC error, but it certainly still has the potential for trouble.

I can add mine fix to Wreck's ROM tonight (NTSC only)

[Kerr Avon]

SubDrag wrote:

It's not a bug and is intentional (but I do appreciate all bug reports). You can't apply most patches together, as the files changed are compressed in the ROM. So mixing and matching patches on the compressed area will either overwrite the other, or cause a crashing hybrid. You have to patch one, then manually update the other ROM. It works a little better in GE, when you need more than one patch we use IPS format, so you don't get a CRC error, but it certainly still has the potential for trouble.

I see. But I'd have thought the creation of a zero bytes long file is a bug? I can't think how it would be desirable.

Quote:

I can add mine fix to Wreck's ROM tonight (NTSC only)

That'd be great, I'd really appreciate it, thanks.

[SubDrag]

I guess I can stop that from happening.